-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move << and >> overloads from Min_circle_2_impl.h to Min_circle_2.h #8716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng_volumes (1)min_annulus_d_fast_exact.cpp (2)min_annulus_d.cpp (3)min_ellipse_2.cpp (4)min_sphere_3.cpp (5)min_sphere_homogenous_3.cpp
Something like that should work:
|
…f Bounding_volumes (1)min_annulus_d_fast_exact.cpp (2)min_annulus_d.cpp (3)min_ellipse_2.cpp (4)min_sphere_3.cpp (5)min_sphere_homogenous_3.cpp" This reverts commit 057caa3.
…erator" This reverts commit 27c788d.
…t compile time" This reverts commit 6b0a8c5.
This reverts commit 93f02cc.
This reverts commit d0f7159.
doesn't seem to work, i'll open a new PR in sometime, sorry for this. |
lrineau
added
the
Not yet approved
The feature or pull-request has not yet been approved.
label
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The current implementation of the
Min_circle_2
class inMin_circle_2.h
, located in theBounding_volumes/include
directory, defines the IO overloads<<
and>>
in a separate file,Min_circle_2_impl.h
. This file is included in the mainMin_circle_2.h
file here.Since the
<<
and>>
overloads are only used within the context of theMin_circle_2.h
file and are not referenced elsewhere in the codebase, these definitions can be moved directly intoMin_circle_2.h
. Consolidating the overloads into the main file improves code organization, making the codebase more streamlined and easier to maintain.Additionally, as noted in the documentation for the
Min_circle_2
class here, theMin_circle_2
class is considered almost obsolete, further supporting the simplification of its current implementation.A few more components of
Bounding_volumes
package can be modified the same way:However, this PR only focuses on
Min_circle_2
Release Management