Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move << and >> overloads from Min_circle_2_impl.h to Min_circle_2.h #8716

Closed
wants to merge 15 commits into from

Conversation

SharonIV0x86
Copy link
Contributor

Summary of Changes

The current implementation of the Min_circle_2 class in Min_circle_2.h, located in the Bounding_volumes/include directory, defines the IO overloads << and >> in a separate file, Min_circle_2_impl.h. This file is included in the main Min_circle_2.h file here.

Since the << and >> overloads are only used within the context of the Min_circle_2.h file and are not referenced elsewhere in the codebase, these definitions can be moved directly into Min_circle_2.h. Consolidating the overloads into the main file improves code organization, making the codebase more streamlined and easier to maintain.

Additionally, as noted in the documentation for the Min_circle_2 class here, the Min_circle_2 class is considered almost obsolete, further supporting the simplification of its current implementation.

A few more components of Bounding_volumes package can be modified the same way:

  • Min_ellipse_2
  • Min_sphere_d
  • Min_sphere_d_impl.h
  • Min_sphere_of_sphere_d

However, this PR only focuses on Min_circle_2

Release Management

  • Affected package(s): Bounding_volumes

@SharonIV0x86
Copy link
Contributor Author

@sloriot i may have made a mistake while opening this PR, the changes of my previous PR are also included in this PR as well. So, how should i proceed? close this PR and reopen a new one with the current changes only?

@sloriot
Copy link
Member

sloriot commented Jan 27, 2025

Something like that should work:

git checkout refact/Min_circle_2
git reset --hard a509669
git push -f

…f Bounding_volumes (1)min_annulus_d_fast_exact.cpp (2)min_annulus_d.cpp (3)min_ellipse_2.cpp (4)min_sphere_3.cpp (5)min_sphere_homogenous_3.cpp"

This reverts commit 057caa3.
This reverts commit b17854f, reversing
changes made to 6b0a8c5.
This reverts commit 93f02cc.
This reverts commit d0f7159.
@SharonIV0x86
Copy link
Contributor Author

Something like that should work:

git checkout refact/Min_circle_2
git reset --hard a509669
git push -f

doesn't seem to work, i'll open a new PR in sometime, sorry for this.

@lrineau lrineau added the Not yet approved The feature or pull-request has not yet been approved. label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not yet approved The feature or pull-request has not yet been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants